Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip testnetify confirmation #516

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Feb 7, 2024

Description

Adds "skip-confirmation" flag that allows infra/devops to automate testnet creation.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@czarcas7ic czarcas7ic merged commit e95dddd into osmo-v22/v0.47.5 Feb 7, 2024
22 of 23 checks passed
@czarcas7ic czarcas7ic deleted the adam/skip-confirmation branch February 7, 2024 23:54
czarcas7ic added a commit that referenced this pull request Feb 8, 2024
* De-dup param getting

* Disable DenomOwners tracking

* Fix some tests

* chore(types): replace amino json encoder with stdlib

* feat: config option to log gRPC queries (#503)

* config option to log gRPC queries

* clarify gRPC log comment

* create var

* remove quotes

* go mod tidy

* chore: fix CI (#509)

* ci

* lints and remove some unnecessary CI jobs

* update tests go mod

* more lints

* remove denom owners since not implemented in osmosis

* more lints

* fix test values

* implement nolint again

* more test fixes

* add back labeler as v4

* remove tabs and slash

* update json to const

* move file locations

* push

* fix seq num issue

* Update tests/e2e/auth/vesting/suite.go

* add back pwd

* remove sonarcloud

---------

Co-authored-by: Matt, Park <[email protected]>

* Fix CI(#511)

* perf: CacheCtx speedups (#504)

* CacheKV speedups

* Remove extra btree alloc

* fix(x/feegrant)!: limit expired feegrant pruning to 200 per block (cosmos#19314) (#512)

Co-authored-by: MSalopek <[email protected]>

* feat: add testnetify logic (#506)

* add testnetify logic

* clarify explanation

* handle errors

* remove testnet app creator

* simplify some logic

* remove redundancy

* lints

* gci imports

* add set store loader method

* trigger upgrade flag

* add extra comments to the CLI command

* skip confirmation (#516)

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Matt, Park <[email protected]>
Co-authored-by: MSalopek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant